This is what the code needs to do.
When a player puts items in to the forge and hits combine button.
ALL item in the forge are removed using the KILL command.
If the player put in the right items in the right amount and he has the right skill
a new item is made.

For example this is some the passable Combinations and the new item made.

Ore X1 + flask of water X1 = Metal bits X2
Metal bits X1 + File mould X1 = metal file X1
Metal bits X4 + metal file X1 = caltrops X1
Metal bits X3 + needle mould X1 + flask of water X1 = sowing needle X4

there are many more but this will give you an idea of that I am doing.

The getItemsIn($OWNER) command "$OWNER is the forge" gos throw each item in the forge
to see if it is there and how many are there. The problem is with so many items that can be put in the
forge to make a valid combine. I end up with a large list of If statements, as you can see from the code.

Is there a way to have it so that when it is going throw the long list If statements and finds that item
and quanty it is that it stop going throw the rest of the if statments.(like a return comand)

For example
If the item is ore. the frist If statment will do the job off recording that ore is presant in forge
and how mach. The other If statment after that one are only deal with other items. So I would like it
to skip the rest of the If statments dealing with the other items to save time.

I was thinking of put each If statment in to one another like so.

If X.name = "Ore"
oreq = oreq + Int(X.Quantity)
Else
If X.name = "Flask of Water"
fwatq = fwatq + Int(X.Quantity)
Else
If X.name = "Medium quality Ore"
mdoreq = mdoreq + Int(X.Quantity)
Else
If X.name = "Smiting hammer"
hamq = hamq + Int(X.Quantity)
Else
If X.name = "Metal File"
fileq = fileq + Int(X.Quantity)
Else
If X.name = "Mould Hammer Head"
mohamq = mohamq + Int(X.Quantity)
End_If
End_If
End_If
End_If
End_If

But this makes the code hard to read and harder to type
with the 17 smiting items add so far I can did it this way but when I add the other 25+ item I made
this code is to hard you event me to keep track off. not mention how long and slow it will when I add
all the passable valid combines.

Do the Dim statements need to be list before I use them in the If Statements?
under the NEXT, when it looks for each of the variable I crated in the Dim commands, If I
do not list them before all the If commands the program will be looking for variables that do not exist.

As far as the use of name to test if the item is present, I will change it to test for type when I
have finished changing over the tag attribute to type.

Any way any thing you can think of shanks the lines the code needed and the time taken to run this
will help a lot.



EVENT Forge1.onComb
Dim oreq = 0
Dim fwatq = 0
Dim mdoreq = 0
Dim hamq = 0
Dim fileq = 0
Dim mohamq = 0
Dim mopotq = 0
Dim moneedq = 0
Dim moarrowq = 0
Dim mostud = 0
Dim mostudq = 0
Dim mofileq = 0
Dim mohookq = 0
Dim bitq = 0
Dim fileq = 0
Dim studq = 0
Dim strapq = 0
Dim sheetq = 0
myset = getItemsIn($OWNER)
For Each X in myset
If X.useskill = "smith"'*****use X.type when the new type system is set up*****
If X.name = "Ore"
oreq = oreq + Int(X.Quantity)
End_If
If X.name = "Flask of Water"
fwatq = fwatq + Int(X.Quantity)
End_If
If X.name = "Medium quality Ore"
mdoreq = mdoreq + Int(X.Quantity)
End_If
If X.name = "Smiting hammer"
hamq = hamq + Int(X.Quantity)
End_If
If X.name = "Metal File"
fileq = fileq + Int(X.Quantity)
End_If
If X.name = "Mould Hammer Head"
mohamq = mohamq + Int(X.Quantity)
End_If
If X.name = "Mould Pot"
mopotq = mopotq + Int(X.Quantity)
End_If
If X.name = "Mould Needle"
moneedq = moneedq + Int(X.Quantity)
End_If
If X.name = "Mould Arrow head"
moarrowq = moarrowq + Int(X.Quantity)
End_If
If X.name = "Mould Studs"
mostudq = mostudq + Int(X.Quantity)
End_If
If X.name = "Mould File"
mofileq = mofileq + Int(X.Quantity)
End_If
If X.name = "Mould Fish hook"
mohookq = mohookq + Int(X.Quantity)
End_If
If X.name = "Metal bits"
bitq = bitq + Int(X.Quantity)
End_If
If X.name = "Metal File"
fileq = fileq + Int(X.Quantity)
End_If
If X.name = "Metal Studs"
studq = studq + Int(X.Quantity)
End_If
If X.name = "Metal Straps"
strapq = strapq + Int(X.Quantity)
End_If
If X.name = "Metal Sheet"
sheetq = sheetq + Int(X.Quantity)
End_If
End_If
KILL X
Next
If oreq >= 1 AND fwatq >= 1' makeing metal bits
If oreq >= fwatq'make the lowest amount
Dim num = Int(fwatq)
Else
Dim num = Int(oreq)
End_If
Dim matix = "C"
Call comSmi(1,num,13,matix)'min,amount,key,mat
Call upSmi(10,80)'put back to 50 after test
End_If
If bitq >= 1 AND mofileq >= 1' makeing metal file
If bitq >= mofileq
Dim num = Int(mofileq)
Else
Dim num = Int(bitq)
End_If
Dim matix = "C"
Call comSmi(5,num,5,matix)'min sill needed,amount to make,key to use,mat to use
Call upSmi(15,80)'put back to 50 after test'max skill,number to get over for success
End_If
If bitq >= 3 AND moneedq >= 1 AND fwatq >= 1' makeing metal sowing needle
If moneedq >= Int(bitq/3) AND fwatq >= Int(bitq/3)
Dim num = Int(bitq/3)
Else
If moneedq <= fwatq
Dim num = Int(moneedq)
Else
Dim num = Int(fwatq)
End_If
End_If
Dim matix = "C"
Call comSmi(10,num,29,matix)'min sill needed,amount to make,key to use,mat to use
Call upSmi(20,80)'put back to 50 after test'max skill,number to get over for success
End_If
End_EVENT

Sub upSmi(max,needed)' max = max skill for the combine, needed = the % you must get over
Dim pre = RndInt(100) + leanB($AGENT)
If pre > needed
If $AGENT.Smiting < max
If $AGENT.Smiting < getMSmi($AGENT)
$AGENT.Smiting = $AGENT.Smiting + 1
Display "GRATZ !! You Have gained a point in Smithing you Smithing Skill is now " + $AGENT.Smiting + " Way to Go!"
Else
Display "You are at the Max for a Level " + $AGENT.Level + " " + $AGENT.Race + " " + $AGENT.Class + " so you gain will not gain any more skill till next level!"
End_If
Else
Display "You Can not Lean any more from this combine! you're skill is to grate"
End_If
End_If
End_Sub

Sub comSmi(min,amount,key,mat)'min = minimum skill needed for combine
If $AGENT.Smiting >= min
Dim base = 100 + Int(min) * 4
Dim sucpre = RndInt(base)
Dim suc = $AGENT.Smiting + Int(stbon($AGENT.STR)) + 20
If sucpre <= suc
If mat = "A"
Call critemA($OWNER,key,amount)
Display "SUCCESS! You have made a " + matANAME(key) + "!"
End_If
If mat = "B"
Call critemB($OWNER,key,amount)
Display "SUCCESS! You have made a " + matBNAME(key) + "!"
End_If
If mat = "C"
Call critemC($OWNER,key,amount)
Display "SUCCESS! You have made " + amount + " " + matCNAME(key) + "!"
End_If
Else
Display "FAILURE! You need to work on your smithing skill"
End_If
Else
Display "You do not have the minimum skill for this combine"
End_If

Hi ricksan,
what you are trying to do can be done esaily by following these guidelines:

1. If you are about to write complex code with several IF branches, don't do it.
Make a Function instead.
Try to elaborate a scheme which is complete enough to handle all your cases and put all your code there.

2. Use SETS. They are great to pack information in some form which can be later unpacked and treated. The Function you make could use sets to apply the same logic to different set of data.

3. Don't use NAME to distinguish objects. Always use the TYPE attribute to distinguish object types. This is a DimensioneX standard, and it is used also for the AutoRestore function. It is likely that in future releases more functions will come up, using this TYPE attribute so you should use it and rely on it.

Now let's dig into your specific case.
Please note that what is below has not been tested so you will have to fix up some things. Post again if you get stuck.

First step

First let us define a SET of recipes. A recipe tells the system what is needed (object types and experience) to make what.

This creates a set of recipes our funtion will read from.
Now the constructed set (use Print to verify) will b something like:

the part before the equal (=) is the key, the part at the right is the value, and expresses what is need to make what is at the left.
It must be clear now that the key part is itself a packed information:

We will make our function to understand this. Now let's assume this part is done and let's go forward. It must be clear that the "X" character is a sort of special character for us so you cannot use it for type identifiers.

Let's look at what is on the right hand of the equal sign. The format is the following:

minimum_experience_needed is a number. Our function will check that you have at least these points of experience for the combination to succeed. If you want you can skip this bit of info if it is useless for you.

Next you have a dot used as a separator

Next you have an ingredients list. This is made as follows:

so here we use the plus sign "+" as list separator .

As we see, in the setRecipes we used four types of separators which cannot be used for other purposes in the string.

Second step

these separate sets of related information. The string can be turned into an Array or set by using standard functions. This task should be done once in the onStart event.

Ok now we have two sets built from the first one:
setRecipesMinExp()
setRecipesIngredients()

we will use it in the function below.


Third step

Next we make a function.

Now we just have to implement a function which is called checkNecessaryIngredients(aPot) which checks inside "aPot" against the list of ingredients for each recipe in the set setRecipeInredients. If found a valid cobination, it returns the key, null otherwise.

Now you simply miss the function IsThere, which has 3 parameters:

Done!

Good luck!